Claudio Schaad
f9084dc074
Every repository, service, Blazor page/dialog, and test now uses
async/await. Single atomic diff; the codebase does not compile in
intermediate states.
- BaseRepository: LoadListAsync/LoadAsync/SaveAsync return Task<T>;
per-file locks use SemaphoreSlim so waiters can await; Save
serialises to a MemoryStream sync (XmlSerializer has no async
form), then File.WriteAllBytesAsync + sync File.Move.
- RepositoryCache.GetOrLoadAsync takes a Func<Task<List<T>>>.
- All 7 repository interfaces + implementations async.
- All service interfaces + implementations async (except vendor
IFxService and stateless IFxConverter / SettingsService).
- Every Blazor OnInitializedAsync switches to await base.
- Test suite fully async, 42 tests pass.
AccountRepository.EnsureAccountsFile keeps two .GetAwaiter().GetResult()
bridges because it runs from the constructor.
Null-render guard follow-up (folded in):
Blazor now renders the component once with fields at their initial
values while OnInitializedAsync awaits — so fields declared `= null!`
are actually null on that first render and things like
`accounts.GroupBy(...)` throw ArgumentNullException. Fixed across
Transactions, BalanceReport, BalanceSheetReport, ProfitLossReport,
DetailReport, Assets, Spendings, SpendingsOverTime, TransactionDialog,
TransactionSplitDialog, and BookingRuleDialog:
- Collection fields initialise to [] so first-render loops are empty.
- Single-object data fields become nullable; the razor wraps
consumption in `@if (field is null) { <p>Lädt…</p> return; }`.
- <PlotlyChart> guarded behind a null check on config/layout/data so
Plotly.Blazor's @bind doesn't see nulls.
- Header/footer strings initialise to "" instead of null!.
Architectural hygiene on a single-user local Blazor Server app: the
observed win is one File.ReadAllBytesAsync and one
File.WriteAllBytesAsync per Load/Save, and after PR D each file is
loaded at most once per SignalR circuit.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
58 lines
1.9 KiB
C#
58 lines
1.9 KiB
C#
using Schaad.Accounting.Repositories;
|
|
using Shouldly;
|
|
|
|
namespace Schaad.Accounting.Tests;
|
|
|
|
public class RepositoryCacheTestShould
|
|
{
|
|
[Fact]
|
|
public async Task CallLoaderOnceWhenKeyIsRequestedRepeatedly()
|
|
{
|
|
var cache = new RepositoryCache();
|
|
var loaderCalls = 0;
|
|
|
|
var first = await cache.GetOrLoadAsync("key", () => { loaderCalls++; return Task.FromResult(new List<int> { 1, 2 }); });
|
|
var second = await cache.GetOrLoadAsync("key", () => { loaderCalls++; return Task.FromResult(new List<int> { 99 }); });
|
|
|
|
loaderCalls.ShouldBe(1);
|
|
second.ShouldBeSameAs(first);
|
|
second.ShouldBe(new[] { 1, 2 });
|
|
}
|
|
|
|
[Fact]
|
|
public async Task KeepEntriesSeparateWhenKeysDiffer()
|
|
{
|
|
var cache = new RepositoryCache();
|
|
|
|
var a = await cache.GetOrLoadAsync("a", () => Task.FromResult(new List<int> { 1 }));
|
|
var b = await cache.GetOrLoadAsync("b", () => Task.FromResult(new List<int> { 2 }));
|
|
|
|
b.ShouldNotBeSameAs(a);
|
|
a.ShouldBe(new[] { 1 });
|
|
b.ShouldBe(new[] { 2 });
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ReloadFromLoaderWhenKeyIsInvalidated()
|
|
{
|
|
var cache = new RepositoryCache();
|
|
var loaderCalls = 0;
|
|
|
|
await cache.GetOrLoadAsync("k", () => { loaderCalls++; return Task.FromResult(new List<int> { 1 }); });
|
|
cache.Invalidate("k");
|
|
await cache.GetOrLoadAsync("k", () => { loaderCalls++; return Task.FromResult(new List<int> { 2 }); });
|
|
|
|
loaderCalls.ShouldBe(2);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task MatchKeysCaseInsensitivelyWhenLookingUp()
|
|
{
|
|
var cache = new RepositoryCache();
|
|
|
|
await cache.GetOrLoadAsync("Path/To/File.xml", () => Task.FromResult(new List<int> { 1 }));
|
|
var upper = await cache.GetOrLoadAsync("PATH/TO/FILE.XML", () => Task.FromResult(new List<int> { 99 }));
|
|
|
|
upper.ShouldBe(new[] { 1 });
|
|
}
|
|
}
|