- Add IMPROVEMENT_PLAN.md with phased plan for follow-up work - Consolidate DI registrations into a single AddAccounting() extension; drop the duplicate service registrations and the PdfParsingService self-registration - TrySetYear: capture this.year before overwriting so rollback actually restores the previous value - DummyFxService: check toCurrency (was checking fromCurrency twice) - TransactionRepository.GetTransaction: return a copy instead of mutating the loaded entity, and guard against unknown ids - ViewService.GetTransactionViewList(accountId): flip the sign on a copy rather than mutating the entity returned by the repository - FileService.GetTransactionListCsv: same treatment; use a local signedValue instead of mutating trx.Value - ProfitLossReport: use ClassIds.Income/Expenses instead of magic 3/4 - CLAUDE.md: correct the ClassIds documentation (1/2/3/4, not 1000/2000/3000/4000) SettingsService lifetime is intentionally left as Singleton for now; making it Scoped requires persisting year/mandator selection across page reloads first (tracked in the plan). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
26 lines
807 B
C#
26 lines
807 B
C#
using Schaad.Finance.Api;
|
|
using System;
|
|
using System.Collections.Generic;
|
|
|
|
namespace Schaad.Accounting.Services
|
|
{
|
|
public class DummyFxService : IFxService
|
|
{
|
|
private List<string> currencies = ["CHF", "EUR", "USD"];
|
|
|
|
public decimal ConvertCurrency(decimal amount, string fromCurrency, string toCurrency, string fixerIoApiKey)
|
|
{
|
|
if (currencies.Contains(fromCurrency) && currencies.Contains(toCurrency))
|
|
{
|
|
return amount;
|
|
}
|
|
|
|
throw new NotImplementedException($"Cannot convert from {fromCurrency} to {toCurrency}");
|
|
}
|
|
|
|
public decimal GetFxRate(string fromCurrency, string toCurrency, DateTime date, string fixerIoApiKey)
|
|
{
|
|
throw new NotImplementedException();
|
|
}
|
|
}
|
|
}
|