Every repository, service, Blazor page/dialog, and test now uses
async/await. Single atomic diff; the codebase does not compile in
intermediate states.
- BaseRepository: LoadListAsync/LoadAsync/SaveAsync return Task<T>;
per-file locks use SemaphoreSlim so waiters can await; Save
serialises to a MemoryStream sync (XmlSerializer has no async
form), then File.WriteAllBytesAsync + sync File.Move.
- RepositoryCache.GetOrLoadAsync takes a Func<Task<List<T>>>.
- All 7 repository interfaces + implementations async.
- All service interfaces + implementations async (except vendor
IFxService and stateless IFxConverter / SettingsService).
- Every Blazor OnInitializedAsync switches to await base.
- Test suite fully async, 42 tests pass.
AccountRepository.EnsureAccountsFile keeps two .GetAwaiter().GetResult()
bridges because it runs from the constructor.
Null-render guard follow-up (folded in):
Blazor now renders the component once with fields at their initial
values while OnInitializedAsync awaits — so fields declared `= null!`
are actually null on that first render and things like
`accounts.GroupBy(...)` throw ArgumentNullException. Fixed across
Transactions, BalanceReport, BalanceSheetReport, ProfitLossReport,
DetailReport, Assets, Spendings, SpendingsOverTime, TransactionDialog,
TransactionSplitDialog, and BookingRuleDialog:
- Collection fields initialise to [] so first-render loops are empty.
- Single-object data fields become nullable; the razor wraps
consumption in `@if (field is null) { <p>Lädt…</p> return; }`.
- <PlotlyChart> guarded behind a null check on config/layout/data so
Plotly.Blazor's @bind doesn't see nulls.
- Header/footer strings initialise to "" instead of null!.
Architectural hygiene on a single-user local Blazor Server app: the
observed win is one File.ReadAllBytesAsync and one
File.WriteAllBytesAsync per Load/Save, and after PR D each file is
loaded at most once per SignalR circuit.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
91 lines
3.3 KiB
C#
91 lines
3.3 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
using Schaad.Accounting.Interfaces;
|
|
using Schaad.Accounting.Models;
|
|
|
|
namespace Schaad.Accounting.Repositories
|
|
{
|
|
public class TransactionRepository : BaseRepository, ITransactionRepository
|
|
{
|
|
private readonly IAccountRepository accountRepository;
|
|
private readonly string TRANSACTIONS = "Transactions.xml";
|
|
|
|
public TransactionRepository(ISettingsService settingsService, RepositoryCache cache, IAccountRepository accountRepository, ILogger<TransactionRepository> logger)
|
|
: base(settingsService, cache, logger)
|
|
{
|
|
this.accountRepository = accountRepository;
|
|
}
|
|
|
|
public Task<List<Transaction>> GetTransactionListAsync() => LoadListAsync<Transaction>(TRANSACTIONS);
|
|
|
|
public async Task SaveTransactionAsync(Transaction transaction)
|
|
{
|
|
transaction.Value = Math.Abs(transaction.Value);
|
|
|
|
var originIsFx = (await accountRepository.GetAccountAsync(transaction.OriginAccountId)).IsFxAccount;
|
|
var targetIsFx = (await accountRepository.GetAccountAsync(transaction.TargetAccountId)).IsFxAccount;
|
|
var isFxAccount = originIsFx || targetIsFx;
|
|
|
|
// user enters amount in the foreign account's currency -> convert to CHF for storage
|
|
if (isFxAccount && transaction.FxRate != 0)
|
|
{
|
|
transaction.Value = transaction.Value * transaction.FxRate.Value;
|
|
}
|
|
|
|
if (!isFxAccount)
|
|
{
|
|
transaction.FxRate = null;
|
|
}
|
|
|
|
if (transaction.BookingDate <= DateTime.MinValue)
|
|
{
|
|
transaction.BookingDate = transaction.ValueDate;
|
|
}
|
|
|
|
var transactionList = await GetTransactionListAsync();
|
|
var idx = transactionList.FindIndex(t => t.Id == transaction.Id);
|
|
if (idx >= 0)
|
|
{
|
|
transactionList[idx] = transaction;
|
|
}
|
|
else
|
|
{
|
|
transaction.Id = Guid.NewGuid().ToString();
|
|
transactionList.Add(transaction);
|
|
}
|
|
await SaveAsync(transactionList, TRANSACTIONS);
|
|
}
|
|
|
|
public async Task<Transaction> GetTransactionAsync(string id)
|
|
{
|
|
var transactions = await GetTransactionListAsync();
|
|
var stored = transactions.FirstOrDefault(t => t.Id == id);
|
|
if (stored == null)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
var result = stored.Clone();
|
|
|
|
// value is stored in CHF -> convert back to foreign currency for display/editing
|
|
var isFxAccount = (await accountRepository.GetAccountAsync(result.OriginAccountId)).IsFxAccount
|
|
|| (await accountRepository.GetAccountAsync(result.TargetAccountId)).IsFxAccount;
|
|
if (isFxAccount && result.FxRate != 0)
|
|
{
|
|
result.Value = result.Value / result.FxRate.Value;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
public async Task DeleteTransactionAsync(string id)
|
|
{
|
|
var transactions = await GetTransactionListAsync();
|
|
transactions.RemoveAll(t => t.Id == id);
|
|
await SaveAsync(transactions, TRANSACTIONS);
|
|
}
|
|
}
|
|
}
|