Claudio Schaad
f9084dc074
Every repository, service, Blazor page/dialog, and test now uses
async/await. Single atomic diff; the codebase does not compile in
intermediate states.
- BaseRepository: LoadListAsync/LoadAsync/SaveAsync return Task<T>;
per-file locks use SemaphoreSlim so waiters can await; Save
serialises to a MemoryStream sync (XmlSerializer has no async
form), then File.WriteAllBytesAsync + sync File.Move.
- RepositoryCache.GetOrLoadAsync takes a Func<Task<List<T>>>.
- All 7 repository interfaces + implementations async.
- All service interfaces + implementations async (except vendor
IFxService and stateless IFxConverter / SettingsService).
- Every Blazor OnInitializedAsync switches to await base.
- Test suite fully async, 42 tests pass.
AccountRepository.EnsureAccountsFile keeps two .GetAwaiter().GetResult()
bridges because it runs from the constructor.
Null-render guard follow-up (folded in):
Blazor now renders the component once with fields at their initial
values while OnInitializedAsync awaits — so fields declared `= null!`
are actually null on that first render and things like
`accounts.GroupBy(...)` throw ArgumentNullException. Fixed across
Transactions, BalanceReport, BalanceSheetReport, ProfitLossReport,
DetailReport, Assets, Spendings, SpendingsOverTime, TransactionDialog,
TransactionSplitDialog, and BookingRuleDialog:
- Collection fields initialise to [] so first-render loops are empty.
- Single-object data fields become nullable; the razor wraps
consumption in `@if (field is null) { <p>Lädt…</p> return; }`.
- <PlotlyChart> guarded behind a null check on config/layout/data so
Plotly.Blazor's @bind doesn't see nulls.
- Header/footer strings initialise to "" instead of null!.
Architectural hygiene on a single-user local Blazor Server app: the
observed win is one File.ReadAllBytesAsync and one
File.WriteAllBytesAsync per Load/Save, and after PR D each file is
loaded at most once per SignalR circuit.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
52 lines
1.7 KiB
C#
52 lines
1.7 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.Extensions.Logging;
|
|
using Schaad.Accounting.Interfaces;
|
|
using Schaad.Accounting.Models;
|
|
|
|
namespace Schaad.Accounting.Repositories
|
|
{
|
|
public class BookingRuleRepository : BaseRepository, IBookingRuleRepository
|
|
{
|
|
private readonly string BOOKING_RULES = "BookingRules.xml";
|
|
|
|
public BookingRuleRepository(ISettingsService settingsService, RepositoryCache cache, ILogger<BookingRuleRepository> logger)
|
|
: base(settingsService, cache, logger)
|
|
{
|
|
EnsureFileExists(BOOKING_RULES);
|
|
}
|
|
|
|
public Task<List<BookingRule>> GetBookingRuleListAsync() => LoadListAsync<BookingRule>(BOOKING_RULES);
|
|
|
|
public async Task SaveBookingRuleAsync(BookingRule bookingRule)
|
|
{
|
|
var bookingRules = await GetBookingRuleListAsync();
|
|
var idx = bookingRules.FindIndex(r => r.Id == bookingRule.Id);
|
|
if (idx >= 0)
|
|
{
|
|
bookingRules[idx] = bookingRule;
|
|
}
|
|
else
|
|
{
|
|
bookingRule.Id = Guid.NewGuid().ToString();
|
|
bookingRules.Add(bookingRule);
|
|
}
|
|
await SaveAsync(bookingRules, BOOKING_RULES);
|
|
}
|
|
|
|
public async Task<BookingRule> GetBookingRuleAsync(string id)
|
|
{
|
|
var bookingRules = await GetBookingRuleListAsync();
|
|
return bookingRules.FirstOrDefault(t => t.Id == id);
|
|
}
|
|
|
|
public async Task DeleteBookingRuleAsync(string id)
|
|
{
|
|
var bookingRules = await GetBookingRuleListAsync();
|
|
bookingRules.RemoveAll(t => t.Id == id);
|
|
await SaveAsync(bookingRules, BOOKING_RULES);
|
|
}
|
|
}
|
|
}
|