Claudio Schaad
f9084dc074
Every repository, service, Blazor page/dialog, and test now uses
async/await. Single atomic diff; the codebase does not compile in
intermediate states.
- BaseRepository: LoadListAsync/LoadAsync/SaveAsync return Task<T>;
per-file locks use SemaphoreSlim so waiters can await; Save
serialises to a MemoryStream sync (XmlSerializer has no async
form), then File.WriteAllBytesAsync + sync File.Move.
- RepositoryCache.GetOrLoadAsync takes a Func<Task<List<T>>>.
- All 7 repository interfaces + implementations async.
- All service interfaces + implementations async (except vendor
IFxService and stateless IFxConverter / SettingsService).
- Every Blazor OnInitializedAsync switches to await base.
- Test suite fully async, 42 tests pass.
AccountRepository.EnsureAccountsFile keeps two .GetAwaiter().GetResult()
bridges because it runs from the constructor.
Null-render guard follow-up (folded in):
Blazor now renders the component once with fields at their initial
values while OnInitializedAsync awaits — so fields declared `= null!`
are actually null on that first render and things like
`accounts.GroupBy(...)` throw ArgumentNullException. Fixed across
Transactions, BalanceReport, BalanceSheetReport, ProfitLossReport,
DetailReport, Assets, Spendings, SpendingsOverTime, TransactionDialog,
TransactionSplitDialog, and BookingRuleDialog:
- Collection fields initialise to [] so first-render loops are empty.
- Single-object data fields become nullable; the razor wraps
consumption in `@if (field is null) { <p>Lädt…</p> return; }`.
- <PlotlyChart> guarded behind a null check on config/layout/data so
Plotly.Blazor's @bind doesn't see nulls.
- Header/footer strings initialise to "" instead of null!.
Architectural hygiene on a single-user local Blazor Server app: the
observed win is one File.ReadAllBytesAsync and one
File.WriteAllBytesAsync per Load/Save, and after PR D each file is
loaded at most once per SignalR circuit.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
104 lines
3.5 KiB
C#
104 lines
3.5 KiB
C#
using Microsoft.AspNetCore.Components;
|
|
using Microsoft.FluentUI.AspNetCore.Components;
|
|
using Schaad.Accounting.Datasets;
|
|
using Schaad.Accounting.Interfaces;
|
|
using Schaad.Accounting.Models;
|
|
using Schaad.Accounting.UI.Components.Pages.Dialogs;
|
|
|
|
namespace Schaad.Accounting.UI.Components.Pages;
|
|
|
|
public partial class Transactions : ComponentBase
|
|
{
|
|
[Inject]
|
|
private IViewService viewService { get; set; } = null!;
|
|
|
|
[Inject]
|
|
private ITransactionRepository transactionRepository { get; set; } = null!;
|
|
|
|
[Inject]
|
|
private IDialogService dialogService { get; set; } = null!;
|
|
|
|
private IReadOnlyList<AccountDataset> accounts = [];
|
|
|
|
private IQueryable<TransactionDataset>? transactionList;
|
|
private string? selectedAccountId;
|
|
private AccountDataset? selectedAccount;
|
|
|
|
protected override async Task OnInitializedAsync()
|
|
{
|
|
accounts = await viewService.GetAccountViewListAsync();
|
|
await ShowTransactionsAsync(accounts.First().Id);
|
|
await base.OnInitializedAsync();
|
|
}
|
|
|
|
private async Task ShowTransactionsAsync(string accountId)
|
|
{
|
|
selectedAccountId = accountId;
|
|
selectedAccount = accounts.Single(a => a.Id == accountId);
|
|
transactionList = (await viewService.GetTransactionViewListAsync(accountId)).AsQueryable();
|
|
}
|
|
|
|
private string GetAccountName(TransactionDataset transaction)
|
|
{
|
|
if (selectedAccountId == transaction.OriginAccountId)
|
|
{
|
|
return transaction.TargetAccount.Name;
|
|
}
|
|
|
|
return transaction.OriginAccount.Name;
|
|
}
|
|
|
|
private async Task AddAsync()
|
|
{
|
|
var data = new Transaction
|
|
{
|
|
ValueDate = DateTime.Now,
|
|
BookingDate = DateTime.Now,
|
|
TargetAccountId = selectedAccountId,
|
|
FxRate = 1
|
|
};
|
|
var dialog = await dialogService.ShowDialogAsync<TransactionDialog>(data, new DialogParameters()
|
|
{
|
|
Height = "500px",
|
|
Title = "Transaktion",
|
|
PreventDismissOnOverlayClick = true,
|
|
PreventScroll = true,
|
|
});
|
|
|
|
var result = await dialog.Result;
|
|
if (!result.Cancelled && result.Data != null)
|
|
{
|
|
transactionList = (await viewService.GetTransactionViewListAsync(selectedAccountId)).AsQueryable();
|
|
}
|
|
}
|
|
|
|
private async Task EditAsync(string id)
|
|
{
|
|
var data = await transactionRepository.GetTransactionAsync(id);
|
|
var dialog = await dialogService.ShowDialogAsync<TransactionDialog>(data, new DialogParameters()
|
|
{
|
|
Height = "500px",
|
|
Title = "Transaktion",
|
|
PreventDismissOnOverlayClick = true,
|
|
PreventScroll = true,
|
|
});
|
|
|
|
var result = await dialog.Result;
|
|
if (!result.Cancelled && result.Data != null)
|
|
{
|
|
transactionList = (await viewService.GetTransactionViewListAsync(selectedAccountId)).AsQueryable();
|
|
}
|
|
}
|
|
|
|
private async Task DeleteAsync(string id)
|
|
{
|
|
var transaction = await transactionRepository.GetTransactionAsync(id);
|
|
var dialog = await dialogService.ShowConfirmationAsync($"Transaction '{transaction.Text}' mit Betrag {transaction.Value} wirklich löschen?", "Ja", "Nein", "Transaktion löschen");
|
|
var result = await dialog.Result;
|
|
if (!result.Cancelled)
|
|
{
|
|
await transactionRepository.DeleteTransactionAsync(id);
|
|
transactionList = (await viewService.GetTransactionViewListAsync(selectedAccountId)).AsQueryable();
|
|
}
|
|
}
|
|
}
|